[Bug 774030] postproc: return GST_FLOW_FLUSHING during flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774030

--- Comment #3 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 339220 [details] [review]:
> 
> ::: gst/vaapi/gstvaapipostproc.c
> @@ +812,2 @@
>        GST_ERROR_OBJECT (postproc, "failed to push output buffer to video
> sink");
> +      return GST_FLOW_ERROR;
> 
> Why not "return ret"?
> 
> @@ +813,3 @@
> +      return GST_FLOW_ERROR;
> +    } else
> +      return GST_FLOW_FLUSHING;
> 
> {}
> 
> @@ +891,2 @@
>        GST_ERROR_OBJECT (postproc, "failed to push output buffer to video
> sink");
> +      return GST_FLOW_EOS;
> 
> Why not "return ret"?
> 
> @@ +892,3 @@
> +      return GST_FLOW_EOS;
> +    } else
> +      return GST_FLOW_FLUSHING;
> 
> {}

Maybe I was afraid a sort of regression? :)
But I totally agree that just do "return ret;"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.