[Bug 774029] vaapiwindow: wayland: fix surface leaks.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774029

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339219|none                        |rejected
             status|                            |

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 339219:
 --> (https://bugzilla.gnome.org/review?bug=774029&attachment=339219)

::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
@@ +384,2 @@
 {
   wl_buffer_destroy (wl_buffer);

I don't understand this change.

Please check the commit e4ed64b7, when this was done because the wayland
protocol is heavily async.

@@ +528,3 @@
+    if (need_vpp && priv->use_vpp) {
+      gst_vaapi_object_unref (surface);
+    }

Here you are hiding the problem. The surface should be unref when the callback
is called from the following wl_buffer_destroy()

Perhaps we have to ensure that the buffer queue is destroyed at error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.