[Bug 774029] vaapiwindow: wayland: fix surface leaks.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774029

--- Comment #3 from Hyunjun Ko <zzoon at igalia.com> ---
Review of attachment 339219:
 --> (https://bugzilla.gnome.org/review?bug=774029&attachment=339219)

::: gst-libs/gst/vaapi/gstvaapiwindow_wayland.c
@@ +383,3 @@
 frame_release_callback (void *data, struct wl_buffer *wl_buffer)
 {
   wl_buffer_destroy (wl_buffer);

That's what I was wondering. 
The problem in this test case (which is simply using vaapisink on gst-launch)
is,
The frame_release_callback for the last wl_buffer is always not called.
What I understand is that this callback is usually called later, probably when
the next buffer is shown.
I need to investigate more for proper fix.

@@ +528,3 @@
+    if (need_vpp && priv->use_vpp) {
+      gst_vaapi_object_unref (surface);
+    }

I don't understand.
There's no callback to unref this surface at this moment, since it is before
even creating frame and adding listener to the wl buffer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.