[Bug 773833] rtpL16depay, rtpL24depay: support depayloading in place

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773833

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339238|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339238:
 --> (https://bugzilla.gnome.org/review?bug=773833&attachment=339238)

Generally looks good, thanks :) Just some minor comments below (also don't put
this "Signed-off-by" thing into the commit message, we're not doing that)

::: gst-libs/gst/audio/audio-channels.c
@@ +131,3 @@
+ * In other words, tells whether channel reordering is needed (unequal) or not
(equal).
+ *
+ * Returns: %TRUE if the channel positions are equal, i.e. no reordering is
needed.

Add a "Since: 1.12" here

Also needs to be added to the .def file in win32/common and
docs/libs/*sections.txt at the right place

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.