[Bug 773833] rtpL16depay, rtpL24depay: support depayloading in place

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773833

--- Comment #9 from Petr Kulhavy <brain at jikos.cz> ---
(In reply to Sebastian Dröge (slomo) from comment #8)
> Review of attachment 339238 [details] [review]:
> 
> Generally looks good, thanks :) Just some minor comments below (also don't
> put this "Signed-off-by" thing into the commit message, we're not doing that)

Ah, ok. That's my habit from Linux kernel to use "git commit -s" for commits
:-)

> ::: gst-libs/gst/audio/audio-channels.c
> @@ +131,3 @@
> + * In other words, tells whether channel reordering is needed (unequal) or
> not (equal).
> + *
> + * Returns: %TRUE if the channel positions are equal, i.e. no reordering is
> needed.
> 
> Add a "Since: 1.12" here
> 
> Also needs to be added to the .def file in win32/common and
> docs/libs/*sections.txt at the right place

Please note that despite the description the function is private (static).
Originally I thought to make it public but then I realized that it's used in
only in the same C file. So I made it static but left the comment there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.