[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339325|none                        |needs-work
             status|                            |

--- Comment #29 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 339325:
 --> (https://bugzilla.gnome.org/review?bug=773473&attachment=339325)

::: configure.ac
@@ -2386,3 @@
 AG_GST_CHECK_FEATURE(KMS, [drm/kms libraries], kms, [
   AG_GST_PKG_CHECK_MODULES(GST_ALLOCATORS, gstreamer-allocators-1.0)
-  PKG_CHECK_MODULES([DRM], [libdrm >= 2.4.55 libkms], HAVE_KMS=yes,
HAVE_KMS=no)

This patch doesn't apply cleanly since the name is KMS_DRM, not DRM as here

::: sys/kms/gstkmsallocator.c
@@ +335,3 @@
   kmsmem = (GstKMSMemory *) mem;
   if (kmsmem->bo)
+    kmsmem->bo->refs--;

did you forget to unmap the bo when refs == 0?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.