[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #30 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Víctor Manuel Jáquez Leal from comment #29)
> Review of attachment 339325 [details] [review]:
> 
> ::: configure.ac
> @@ -2386,3 @@
>  AG_GST_CHECK_FEATURE(KMS, [drm/kms libraries], kms, [
>    AG_GST_PKG_CHECK_MODULES(GST_ALLOCATORS, gstreamer-allocators-1.0)
> -  PKG_CHECK_MODULES([DRM], [libdrm >= 2.4.55 libkms], HAVE_KMS=yes,
> HAVE_KMS=no)
> 
> This patch doesn't apply cleanly since the name is KMS_DRM, not DRM as here

Whoops. I wrote the patches against 1.10.0 instead of master.

> ::: sys/kms/gstkmsallocator.c
> @@ +335,3 @@
>    kmsmem = (GstKMSMemory *) mem;
>    if (kmsmem->bo)
> +    kmsmem->bo->refs--;
> 
> did you forget to unmap the bo when refs == 0?

The buffer object is unmapped and destroyed in gst_kms_allocator_memory_reset.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.