[Bug 774108] Two warnings while building with mingw64

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 9 07:25:47 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774108

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339334|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339334:
 --> (https://bugzilla.gnome.org/review?bug=774108&attachment=339334)

::: tests/misc/netclock-replay.c
@@ +23,3 @@
 /* We need the internal netclock estimation function to (re)run the code on
+ captured samples, plus its dependencies for the build to succeed. */
+#undef __MSVCRT_VERSION__

This will fail on non-Windows as it's not defined. The better solution would be
to add at the very top of the source file:

> #ifdef HAVE_CONFIG_H
> #include "config.h"
> #endif

Before all other includes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list