[Bug 774108] Two warnings while building with mingw64

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 9 13:20:16 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774108

--- Comment #5 from Victor Toso <bugzilla at victortoso.com> ---
(In reply to Sebastian Dröge (slomo) from comment #4)
> Review of attachment 339334 [details] [review]:
> 
> ::: tests/misc/netclock-replay.c
> @@ +23,3 @@
>  /* We need the internal netclock estimation function to (re)run the code on
> + captured samples, plus its dependencies for the build to succeed. */
> +#undef __MSVCRT_VERSION__
> 
> This will fail on non-Windows as it's not defined.

My bad in not testing this properly.

> The better solution would
> be to add at the very top of the source file:
> 
> > #ifdef HAVE_CONFIG_H
> > #include "config.h"
> > #endif
> 
> Before all other includes.

Ah, sure. I'll submit v2 shortly. Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list