[Bug 772740] rtpbin: receiving RTP bundle support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Nov 11 15:05:10 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=772740

--- Comment #15 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 339371:
 --> (https://bugzilla.gnome.org/review?bug=772740&attachment=339371)

::: gst/rtpmanager/gstrtpbin.c
@@ +712,3 @@
+  }
+
+  gst_pad_link (src_pad, recv_rtp_sink);

Please check the return value of gst_pad_link(), if you're 100% sure it will
always work, try gst_pad_link_full(,GST_PAD_LINK_CHECK_NOTHING). That is only
ok if there is nothing linked on the outside yet on either side of the link.

@@ +3154,3 @@
   rtpbin = stream->bin;

+  GST_DEBUG ("new payload pad %u", pt);

Any reason this is not GST_DEBUG_OBJECT() ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list