[Bug 772740] rtpbin: receiving RTP bundle support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772740

--- Comment #16 from Philippe Normand <philn at igalia.com> ---
(In reply to Olivier Crête from comment #15)
> Review of attachment 339371 [details] [review]:
> 
> ::: gst/rtpmanager/gstrtpbin.c
> @@ +712,3 @@
> +  }
> +
> +  gst_pad_link (src_pad, recv_rtp_sink);
> 
> Please check the return value of gst_pad_link(), if you're 100% sure it will
> always work, try gst_pad_link_full(,GST_PAD_LINK_CHECK_NOTHING). That is
> only ok if there is nothing linked on the outside yet on either side of the
> link.
> 

I'll check the gst_pad_link() result. The alternative can't be used, i'm
afraid.

> @@ +3154,3 @@
>    rtpbin = stream->bin;
>  
> +  GST_DEBUG ("new payload pad %u", pt);
> 
> Any reason this is not GST_DEBUG_OBJECT() ?

I suppose not! Originally I was only fixing the format string :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.