[Bug 774196] mpdparser: Fix timestamp setting on fragment

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Nov 12 12:10:08 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=774196

--- Comment #16 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 339678:
 --> (https://bugzilla.gnome.org/review?bug=774196&attachment=339678)

Looks ok to me but I'm unaware of how DLNA works in detail. I guess it also
sends TIME segments from the source?

::: gst/isomp4/qtdemux.c
@@ +2168,3 @@
+      if (!(demux->upstream_format_is_time && demux->fragmented)) {
+        /* accept upstream's notion of segment and distribute along */
+        segment.format = GST_FORMAT_TIME;

My main concern is ending up with segment.format != TIME for qtdemux as it
always expect it to be time but I guess the upstream_format_is_time check will
get that right.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list