[Bug 774196] mpdparser: Fix timestamp setting on fragment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774196

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #16)
> Review of attachment 339678 [details] [review]:
> 
> Looks ok to me but I'm unaware of how DLNA works in detail. I guess it also
> sends TIME segments from the source?

We have no DLNA support, and if something sends TIME segments these should be
considered in any case instead of overriding them with something parsed from
the stream.

> ::: gst/isomp4/qtdemux.c
> @@ +2168,3 @@
> +      if (!(demux->upstream_format_is_time && demux->fragmented)) {
> +        /* accept upstream's notion of segment and distribute along */
> +        segment.format = GST_FORMAT_TIME;
> 
> My main concern is ending up with segment.format != TIME for qtdemux as it
> always expect it to be time but I guess the upstream_format_is_time check
> will get that right.

Yeah

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.