[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to John Poet from comment #25)
> (In reply to Sebastian Dröge (slomo) from comment #21)
> > Review of attachment 339845 [details] [review] [review]:
> > 
> > ::: gst-libs/gst/vanc/gstvancmeta.c
> > @@ +77,3 @@
> > +
> > +  } else {
> > +    GST_WARNING ("gst_vanc_meta_transform type not supported");
> > 
> > I think you should do the same for all transforms, there is no possible
> > transform that would make the vanc metadata invalid. It's like a separate
> > stream, right?
> 
> If I take out support for the COPY transform, nothing shows up at the
> receiving end.  Or, am I misunderstanding what you are asking here?

I meant doing what you do for COPY right now for all transforms.

> > ::: pkgconfig/gstreamer-plugins-bad-uninstalled.pc.in
> > @@ +11,3 @@
> >  Version: @VERSION@
> >  Requires: gstreamer- at GST_API_VERSION@
> > +Libs: -L at abs_top_builddir@/gst-libs/gst/audio/.libs
> > -L at abs_top_builddir@/gst-libs/gst/basecamerabinsrc/.libs
> > -L at abs_top_builddir@/gst-libs/gst/codecparsers/.libs
> > -L at abs_top_builddir@/gst-libs/gst/gl/.libs
> > -L at abs_top_builddir@/gst-libs/gst/insertbin/.libs
> > -L at abs_top_builddir@/gst-libs/gst/interfaces/.libs
> > -L at abs_top_builddir@/gst-libs/gst/mpegts/.libs
> > -L at abs_top_builddir@/gst-libs/gst/player/.libs
> > -L at abs_top_builddir@/gst-libs/gst/signalprocessor/.libs
> > -L at abs_top_builddir@/gst-libs/gst/video/.libs
> > -L at abs_top_builddir@/gst-libs/gst/vanc/.libs
> > -L at abs_top_builddir@/gst-libs/gst/wayland/.libs
> > 
> > Should also add a (two) pkg-config files for the vanc library alone
> 
> You want me to create:
> pkgconfig/gstreamer-vanc.pc
> pkgconfig/gstreamer-vanc-1.0-uninstalled.pc
> ?  If so, Should it be libvanc or just vanc?

Yes (the unversioned .pc.in are the files you add, the others are generated).
Should be gstreamer-vanc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.