[Bug 773863] decklinkvideosrc: add VANC parsing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773863

--- Comment #27 from John Poet <jppoet at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #23)
> Review of attachment 339847 [details] [review]:
> ::: sys/decklink/gstdecklinkvideosrc.cpp
> @@ +707,1 @@
>    w (*buffer, f->tc);
> 
> How many vanc metas are added? Adding a meta to a buffer is literally just
> appending an item to a linked list. In any order, none of the things should
> disappear.


In my tests, I am seeing between 3 and 5 per frame.  All of them show up at the
receiving end when gst_buffer_add_video_time_code_meta does not get in the way.


> Can you check in the gst_buffer_add_meta() code what goes wrong there?


My gst_buffer_foreach_meta() function was returning FALSE if it was not a
GstVANCMeta.  This caused the foreach function to abort processing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.