[Bug 774641] gst-editing-services: Enable building with MSVC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774641

--- Comment #9 from Scott D Phillips <scott.d.phillips at intel.com> ---
(In reply to Thibault Saunier from comment #5)
> Review of attachment 340178 [details] [review]:
> 
> Looks like they came up with a more complex solution in GStreamer core:
> https://phabricator.freedesktop.org/diffusion/GST/browse/master/gst/parse/
> meson.build;fa3eac2d28e0006f7bf555c866b1daefd15c278b$22 any downside of
> disabling unistd on unix systems?

No, your lexer code either uses posix stuff from unistd.h or it does not, so
we'll know if this is good or not at build time. flex always includes unistd.h
for your convenience AFAICT. Disabling including it just with msvc is probably
asking for trouble because at some point you might start using some unistd
stuff. You'll see everything compile and work on linux but then the build
breaks on windows. If we just never include unistd then won't get that
situation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.