[Bug 774641] gst-editing-services: Enable building with MSVC

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774641

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340178|reviewed                    |accepted-commit_now
             status|                            |

--- Comment #10 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 340178:
 --> (https://bugzilla.gnome.org/review?bug=774641&attachment=340178)

> No, your lexer code either uses posix stuff from unistd.h or it does not, so we'll know if this is good or not at build time. flex always includes unistd.h for your convenience AFAICT. Disabling including it just with msvc is probably asking for trouble because at some point you might start using some unistd stuff. You'll see everything compile and work on linux but then the build breaks on windows. If we just never include unistd then won't get that situation.

OK then :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.