[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #43 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Víctor Manuel Jáquez Leal from comment #42)
> Review of attachment 339328 [details] [review]:
> 
> ::: sys/kms/gstkmssink.c
> @@ +417,3 @@
> +    count_modes = conn->count_modes;
> +  else
> +    count_modes = 1;
> 
> here seems to be the problem: if we change it to 
> 
> if (conn)
>   count_modes = conn->count_modes;
> 
> if (count_modes == 0)
>   count_modes = 1;

It sounds like the kms driver does not correctly report the supported modes.
Without this information, the kmssink does not know the available modes and
won't be able to set the mode.

I thought that if a connector is found, the connector would always report
supported modes. If there are connectors which do not report modes, the
condition should be cheched in gst_kms_sink_start() after find_main_monitor() 
and modesetting should be disabled entirely, falling back to using planes.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.