[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #44 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Víctor Manuel Jáquez Leal from comment #40)
> Review of attachment 339326 [details] [review]:
> 
> ::: sys/kms/gstkmssink.c
> @@ +1220,3 @@
> +      goto bail;
> +
> +    goto skip_set_plane;
> 
> Just to get the facts right. Does this mean that, if modesetting_enabled ==
> TRUE, the buffer is going to be ALWAYS flipped WITHOUT SetPlane() being
> called?? Is this another rendering code path?
> 
> The cropping meta will be ignored. Is that correct?

Yes, if modesetting is enabled, the page flip will flip to the kms_memory that
backs the current GstBuffer, i.e., set it as the current framebuffer and ignore
the cropping meta.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.