[Bug 773473] kmssink: support display mode setting

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 24 08:31:12 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #45 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Víctor Manuel Jáquez Leal from comment #37)
> Comment on attachment 340140 [details] [review]
> 0001-kmssink-remove-dependency-on-libkms.patch
> 
> I've polished the commit
> 
> * initialize the ioctl argument structure rather than memset
> * clean up the header includes
> * initlized with g_malloc0() kms_bo structure (and use g_free)
> * move the definition of kms_bo structure into the gstkmsallocator.c
> * updated the meson.build file
> * removed the kms_driver structure
> * changed ensure_kms_driver() to check_fd()
> * use g_atomic_int_*() to handle the mapping count reference

Thanks for the polishing. I'll try to learn from it for the future. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list