[Bug 755036] mssdemux: improved live playback support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Nov 29 11:43:09 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=755036

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #340963|none                        |reviewed
             status|                            |

--- Comment #19 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 340963:
 --> (https://bugzilla.gnome.org/review?bug=755036&attachment=340963)

Looks good.  Feel free to push after the change below.

::: ext/smoothstreaming/gstmssmanifest.c
@@ +1626,3 @@
+      gst_mss_stream_type_name (gst_mss_stream_get_type (stream));
+
+  for (guint8 index = 0; index < stream->fragment_parser.tfrf.entries_count;

C99. Move the declaration of index out of the for loop.

Also, weren't you going to make index not the size of a byte?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list