[Bug 755036] mssdemux: improved live playback support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755036

--- Comment #20 from Philippe Normand <philn at igalia.com> ---
(In reply to Matthew Waters (ystreet00) from comment #19)
> Review of attachment 340963 [details] [review]:
> 
> Looks good.  Feel free to push after the change below.
> 

Ok, thanks for the reviews!

> ::: ext/smoothstreaming/gstmssmanifest.c
> @@ +1626,3 @@
> +      gst_mss_stream_type_name (gst_mss_stream_get_type (stream));
> +
> +  for (guint8 index = 0; index < stream->fragment_parser.tfrf.entries_count;
> 
> C99. Move the declaration of index out of the for loop.
> 

Oops

> Also, weren't you going to make index not the size of a byte?

Well the FragmentCount field is defined as uint8 in the spec
https://msdn.microsoft.com/en-us/library/ff469518.aspx

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.