[Bug 772608] rpi/dispmanx: Implement gst_video_overlay_set_window_handle() for dispmanx window

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772608

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337276|none                        |needs-work
             status|                            |

--- Comment #16 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 337276:
 --> (https://bugzilla.gnome.org/review?bug=772608&attachment=337276)

This is not what we discussed.

1. in set_window_handle(), set the foreign handle.
2. when we need the window created to render into, copy the foreign handle to
the native handle.

::: gst-libs/gst/gl/dispmanx/gstglwindow_dispmanx_egl.c
@@ +172,3 @@
+  if (window_egl->forgein.element)
+    return (guintptr) & window_egl->forgein;
+  else if (window_egl->native.element)

Is this hunk specifically needed?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.