[Bug 772608] rpi/dispmanx: Implement gst_video_overlay_set_window_handle() for dispmanx window

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772608

--- Comment #17 from Munez <munezbn.dev at gmail.com> ---
(In reply to Matthew Waters (ystreet00) from comment #16)
> Review of attachment 337276 [details] [review]:
> 
> This is not what we discussed.
> 
I am little confused because I am new to gstreamer and not sure about the
sequence. for e.g what is the call sequence when there is a custom(foreign)
window set and when there is no custom window set.. Please bear with me for my
bad patches :)

> 1. in set_window_handle(), set the foreign handle.

So this part of patch is fine right ? I have added a new foreign handle and
setting it in set_window handle

> 2. when we need the window created to render into, copy the foreign handle
> to the native handle.
> 
a] Now I am not sure when exactly this happens. From app side we set the window
handle when we receive prepare_window_handle message. So which function is the
right place ?
b] When you say copy foreign handle did you mean copying only dispmanx element
? i.e  window_egl->native.element = window_egl->foreign.element.
c] if case b] right then we need to remove the native.element(if it is valid)
from dispmanx layer before assigning the foreign element right? 

> ::: gst-libs/gst/gl/dispmanx/gstglwindow_dispmanx_egl.c
> @@ +172,3 @@
> +  if (window_egl->forgein.element)
> +    return (guintptr) & window_egl->forgein;
> +  else if (window_egl->native.element)
> 
> Is this hunk specifically needed?

Not required if we are copying foreign element to native element.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.