[Bug 772608] rpi/dispmanx: Implement gst_video_overlay_set_window_handle() for dispmanx window

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772608

--- Comment #18 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Munez from comment #17)
> > 1. in set_window_handle(), set the foreign handle.
> 
> So this part of patch is fine right ? I have added a new foreign handle and
> setting it in set_window handle

Yes.

> > 2. when we need the window created to render into, copy the foreign handle
> > to the native handle.
> > 
> a] Now I am not sure when exactly this happens. From app side we set the
> window handle when we receive prepare_window_handle message. So which
> function is the right place ?

Whenever it's being created in the original code.  Instead of creating the
dispmanx element, we use the foreign window.

> b] When you say copy foreign handle did you mean copying only dispmanx
> element ? i.e  window_egl->native.element = window_egl->foreign.element.

We copy all of it, the element, width and height.

> c] if case b] right then we need to remove the native.element(if it is
> valid) from dispmanx layer before assigning the foreign element right? 

Not sure what you mean by this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.