[Bug 772468] basesink: Don't nest prepare/render calls

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=772468

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337004|none                        |reviewed
             status|                            |

--- Comment #2 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 337004:
 --> (https://bugzilla.gnome.org/review?bug=772468&attachment=337004)

One question.

::: libs/gst/base/gstbasesink.c
@@ +3419,2 @@
     if (G_UNLIKELY (late))
       goto dropped;

Don't we always want to preroll without dropping?

i.e. move the new code above this if?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.