[Bug 772468] basesink: Don't nest prepare/render calls
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Oct 19 14:01:07 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=772468
--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Matthew Waters (ystreet00) from comment #2)
> Review of attachment 337004 [details] [review]:
>
> One question.
>
> ::: libs/gst/base/gstbasesink.c
> @@ +3419,2 @@
> if (G_UNLIKELY (late))
> goto dropped;
>
> Don't we always want to preroll without dropping?
>
> i.e. move the new code above this if?
Yes, looks right. It looks like this minor bug existed before this patch.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list