[Bug 773261] gstplayer: Add some gstplayer API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773261

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338080|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338080:
 --> (https://bugzilla.gnome.org/review?bug=773261&attachment=338080)

Please split this into two patches

::: gst-libs/gst/player/gstplayer.h
@@ +200,3 @@
+guint  gst_player_get_video_num (GstPlayer * player);
+
+guint  gst_player_get_subtitle_num (GstPlayer * player);

These 3 functions are not needed. You can already get the same information from
the media info

@@ +213,3 @@
+GstElement * gst_player_get_audio_sink(GstPlayer * player);
+
+GstElement * gst_player_get_text_sink(GstPlayer * player);

For video sinks, there is the GstPlayerVideoRenderer interface (for the video
overlay implementation one could think of adding sink selection by factory name
though). For audio/text sinks I would prefer to also have some abstraction here
instead of exposing GStreamer internals that much

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.