[Bug 773261] gstplayer: Add some gstplayer API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773261

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338081|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338081:
 --> (https://bugzilla.gnome.org/review?bug=773261&attachment=338081)

::: gst-libs/gst/player/gstplayer.c
@@ +4489,3 @@
+    g_object_set(G_OBJECT(video_sink), "reconfig", 1, NULL);
+  } else if (g_object_class_find_property (gobjclass,"rotate-method")) {
+    g_object_set(G_OBJECT(video_sink), "rotate-method", rotation/90, NULL);

Rotation should be handled via the GstVideoDirection interface, and we should
expose the enum of it here. This should also be inside the video renderer
interface probably

@@ +4564,3 @@
+    g_object_get(G_OBJECT(video_sink), "overlay-top", &area->offsety, NULL);
+    g_object_get(G_OBJECT(video_sink), "overlay-width", &area->width, NULL);
+    g_object_get(G_OBJECT(video_sink), "overlay-height", &area->height, NULL);

This is all non-standard and not provided by any of our sinks. Also see the
other comments

::: gst-libs/gst/player/gstplayer.h
@@ +236,3 @@
+void gst_player_expose_video(GstPlayer * player);
+
+gboolean gst_player_set_window(GstPlayer * player, guintptr winhandle);

This should be part of the GstPlayerVideoRenderer interface or specific
implementations, and everything but the first two functions are part of the
GstPlayerVideoOverlayVideoRenderer implementation

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.