[Bug 773261] gstplayer: Add some gstplayer API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773261

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338083|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338083:
 --> (https://bugzilla.gnome.org/review?bug=773261&attachment=338083)

::: gst-libs/gst/player/gstplayer.h
@@ +244,3 @@
+    gint width;
+    gint height;
+}image_info;

This should be a proper type, e.g. a GstSample. It should contain information
about the format (caps) and some kind of better memory abstraction.

@@ +247,3 @@
+
+gboolean gst_player_get_video_thumbnail(GstPlayer * player, gint sec,
+      image_info *thumbnail);

It should probably not do any seeks but get a snapshot of the current position
(last-sample property), and convert it to another format if needed (OTOH that's
easily done with the gst_video_convert_sample() API).


If you need thumbnails at arbitrary positions, this seems like something for
which there should be a separate API. not GstPlayer. Some thumbnailing API
inside GstDiscoverer probably.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.