[Bug 773261] gstplayer: Add some gstplayer API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773261

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338085|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338085:
 --> (https://bugzilla.gnome.org/review?bug=773261&attachment=338085)

::: gst-libs/gst/player/gstplayer.c
@@ +4833,3 @@
+  g_return_val_if_fail (GST_IS_PLAYER (self), FALSE);
+
+  element = gst_bin_get_by_name (GST_BIN (self->playbin),
"overlay");//textoverlay

This can't really work and will always be NULL. You could get the
subtitleoverlay from playsink probably, and set these things on it. But that
will also only work for font-desc and subtitle-encoding, not the positioning.

Also the positioning depends a lot on the subtitle format and renderer (OTOH
the other settings too).


All this should probably get settings on playsink first, and then we can expose
those here

::: gst-libs/gst/player/gstplayer.h
@@ +265,3 @@
+  SUBTITLE_V_ALIGN_POSITION = 3,
+  SUBTITLE_V_ALIGN_CENTER   = 4
+} SubtitleVAlign;

Types and enums need proper namespacing

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.