[Bug 773261] gstplayer: Add some gstplayer API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773261

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Sebastian Dröge (slomo) from comment #7)
> Review of attachment 338081 [details] [review]:
> 
> ::: gst-libs/gst/player/gstplayer.c
> @@ +4489,3 @@
> +    g_object_set(G_OBJECT(video_sink), "reconfig", 1, NULL);
> +  } else if (g_object_class_find_property (gobjclass,"rotate-method")) {
> +    g_object_set(G_OBJECT(video_sink), "rotate-method", rotation/90, NULL);
> 
> Rotation should be handled via the GstVideoDirection interface, and we
> should expose the enum of it here. This should also be inside the video
> renderer interface probably

See also bug #765309 for the rotation. Should be handled in that bug.


It would probably also make sense to create one bug per feature and then we can
discuss the specific details there. API-wise, some discussions are needed here
to find a good solution.


In any case, thanks for all your patches :) We should try to find appropriate
API for all these features for GstPlayer, they all seem useful to have.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.