[Bug 773269] rtpbin: avoid generating errors when rtcp messages are empty and check the queue is not empty

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773269

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338336|none                        |accepted-commit_after_freez
             status|                            |e

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338336:
 --> (https://bugzilla.gnome.org/review?bug=773269&attachment=338336)

Looks generally good, thanks :)

::: gst/rtpmanager/rtpsession.c
@@ +3973,3 @@
   GHashTable *table_copy;
   ReportOutput *output;
+  gboolean all_empty = FALSE;

Why initialize to FALSE...

@@ +4038,3 @@

+  /* check if all the buffers are empty afer generation */
+  all_empty = TRUE;

...and then always set to TRUE here? (Also typo: afer)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.