[Bug 773269] rtpbin: avoid generating errors when rtcp messages are empty and check the queue is not empty

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773269

--- Comment #16 from Alejandro G. Castro <alex at igalia.com> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> Review of attachment 338336 [details] [review]:
> 
> Looks generally good, thanks :)
> 
> ::: gst/rtpmanager/rtpsession.c
> @@ +3973,3 @@
>    GHashTable *table_copy;
>    ReportOutput *output;
> +  gboolean all_empty = FALSE;
> 
> Why initialize to FALSE...
> 
> @@ +4038,3 @@
>  
> +  /* check if all the buffers are empty afer generation */
> +  all_empty = TRUE;
> 
> ...and then always set to TRUE here? (Also typo: afer)

The if before that line goes directly to done depending on the time, we do not
want to launch and error in that case because we basically avoided the
generation. The if is:

  /* see if we need to generate SR or RR packets */
  if (!is_rtcp_time (sess, current_time, &data))
    goto done;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.