[Bug 773073] audioconvert: endian conversion optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773073

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338519|none                        |accepted-commit_after_freez
             status|                            |e

--- Comment #50 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 338519:
 --> (https://bugzilla.gnome.org/review?bug=773073&attachment=338519)

Good except for (mostly) cosmetics, thanks :)

::: gst-libs/gst/audio/audio-converter.c
@@ +972,3 @@
+{
+  guint64 *out = dst;
+  const guint64 *in = src;

I wonder if "const guint64*" and "guint64*" are considered different types and
aliasing bites us again here... should be ok to get rid of the const here and
in the function signature

::: gst-libs/gst/audio/gstaudiopack.orc
@@ -423,3 @@
 muld t1, s1, 2147483648.0L
 convdl d1, t1
-

Spurious whitespace change here

::: gst/audioconvert/gstaudioconvert.c
@@ +791,3 @@
+  g_assert (gst_audio_converter_supports_inplace (this->convert));
+
+  return gst_audio_convert_transform (base, buf, buf);

Maybe add a comment to transform() that it can be called with in==out from here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.