[Bug 773073] audioconvert: endian conversion optimization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773073

--- Comment #51 from Petr Kulhavy <brain at jikos.cz> ---
(In reply to Sebastian Dröge (slomo) from comment #50)
> Review of attachment 338519 [details] [review]:
> 
> Good except for (mostly) cosmetics, thanks :)
> 
> ::: gst-libs/gst/audio/audio-converter.c
> @@ +972,3 @@
> +{
> +  guint64 *out = dst;
> +  const guint64 *in = src;
> 
> I wonder if "const guint64*" and "guint64*" are considered different types
> and aliasing bites us again here... should be ok to get rid of the const
> here and in the function signature

In my understanding it should be ok. const int *x and int *y pointing to the
same chunk of memory are absolutely legal in C. The const just means the value
cannot be changed through x, but it doesn't mean that the value in memory
doesn't change. See also e.g. the memmove(), where the src pointer is also
const. At the same time memmove() can be called with overlapping buffers.

> 
> ::: gst-libs/gst/audio/gstaudiopack.orc
> @@ -423,3 @@
>  muld t1, s1, 2147483648.0L
>  convdl d1, t1
> -
> 
> Spurious whitespace change here

That one slipped through, thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.