[Bug 770461] flacenc: Implement flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770461

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #335367|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 335367
  --> https://bugzilla.gnome.org/attachment.cgi?id=335367
flacenc: Implement flushing

>+    case GST_EVENT_FLUSH_START:
>+      flacenc->flushing = TRUE;
>+      ...
>+      break;
>+    case GST_EVENT_FLUSH_STOP:
>+      if (!flacenc->encoding) {
>+        flacenc->flushing = FALSE;
...

Since FLUSH_START will be called from a thread other than the streaming thread,
this is not really thread-safe without locking (setting flacenc->flushing in
FLUSH_START and reading it in the coder elsewhere).

Ideally you'd do nothing in FLUSH_START and only flush/reset the encoder in
FLUSH_STOP I think. Is that possible?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.