[Bug 770461] flacenc: Implement flushing

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 13 17:22:55 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=770461

--- Comment #3 from GstBlub <gstblub at gmail.com> ---
Thanks for the feedback.  I'll update the patch with more locking.

The issue I'm seeing is that it is sitting in gst_flac_enc_write_callback()
trying to push the buffer, which is called by either
FLAC__stream_encoder_process_interleaved() or FLAC__stream_encoder_finish(). 
However the FLUSH_START can come in when it is sitting there, so from that
point on I need to somehow clear the encoder so that it doesn't keep pushing
buffers into gst_audio_encoder_finish_frame().  Which is what triggers this
warning.  Also, since it is sitting in the FLAC__*() calls, if I didn't
remember that a FLUSH_START happened then it could be possible to receive a
FLUSH_STOP and not having actually flushed anything.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list