[Bug 771261] opusenc: add signal-type property

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 13 13:08:52 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=771261

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I wonder if we should do all of this (including bug #771262 and bug #771263) a
bit differently. Maybe merge those bugs into one so we can deal with all of it
in one go.

The current property is a bit weird indeed, not sure how that slipped though :)

And we should not have exposed the opus values directly, but made our own enum
and then mapped that to the opus values.

So I wonder if what we should do is:

 - change what "audio-type" does under the hood to OPUS_SET_SIGNAL

 - add new "sane" enum values for "audio-type" and deprecate the existing ones

 - add a new "application-type" property for the latency/coding trade-offs

 - if "audio-type" is set to the deprecated voice type we default to the
appropriate voip application-type if application-type hasn't been set
explicitly already.

How does that sound?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list