[Bug 771261] opusenc: add signal-type property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771261

--- Comment #2 from Marcin Lewandowski <marcin at saepia.net> ---
Generally speaking I agree with your proposal to make this done right.

Except:

1. I think audio-type should remain as it is, it definitely should not silently
change behaviour, just should be marked as deprecated and removed in the
future. I imagine all these angry developers that figure out that their app
started to work differently after upgrade of GStreamer.

Then we can add signal-type, that matches Opus naming (which IMO is itself a
plus), that uses OPUS_SET_SIGNAL under the hood.

2. I think we should not touch enums of existing properties, I've seen apps in
the wild that use "insane" values that are taken straight from Opus. Such
change will break them.


I initially didn't wanted to change the API of opusenc, but if you agree to do
so I can prepare the patch that merges all these fixes. Please confirm :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.