[Bug 711155] wayland: add DMABuf support to wayland sink

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 23 14:39:15 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=711155

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336061|none                        |needs-work
             status|                            |

--- Comment #90 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 336061:
 --> (https://bugzilla.gnome.org/review?bug=711155&attachment=336061)

Nothing major come out this time, this is nearly ready for 1.11.

::: ext/wayland/wldisplay.c
@@ +166,3 @@
+
+gboolean
+is_shm_format_supported (enum wl_shm_format format_shm, GstWlDisplay *
display)

Namespace missing.

@@ +181,3 @@
+
+gboolean
+is_dmabuf_format_supported (guint format_dmabuf, GstWlDisplay * display)

Namespace missing.

@@ +334,3 @@

+  if (!self->dmabuf) {
+    g_warning ("Could not bind to zwp_linux_dmabuf_v1");

Should be a GST_INFO() instead, logged in the PERFORMANCE category.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list