[Bug 729276] audioresample: Misdetected and/or misused intrinsics headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=729276

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #336446|none                        |needs-work
             status|                            |

--- Comment #27 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 336446:
 --> (https://bugzilla.gnome.org/review?bug=729276&attachment=336446)

Almost good to go :)

::: gst-libs/gst/audio/Makefile.am
@@ +111,3 @@
+libaudio_resampler_sse_la_CFLAGS = \
+    $(libgstaudio_ at GST_API_VERSION@_la_CFLAGS) \
+    -msse

You still need to ensure to only do that if the compiler supports this very
flag. Needs a configure check

Should probably also check for the relevant intrinsics headers.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.