[Bug 773473] kmssink: support display mode setting

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Apr 2 15:27:42 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=773473

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #52 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Not entirely sure about this patch:

commit 3d0c5dd58e2d8383f6f2d9d8a9d759fca25ee61d
Author: Michael Tretter <m.tretter at pengutronix.de>
Date:   Tue Nov 8 15:27:51 2016 +0100

    kmssink: allow only supported resolutions

    If the input buffers have a different size than the display, the frames
    would have to be scaled or positioned on the display. The kmssink cannot
    decide which behaviour would be appropriate for which use case.

    In order to avoid scaling or positioning of the input stream, allow only
    the supported connector resolutions in the sink caps.

    https://bugzilla.gnome.org/show_bug.cgi?id=773473

    Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>


Wouldn't the more logical thing to do be to either make it a property or take
the simplest approach to make things work? (Here probably:
positioning/cropping)

Compare with ximagesink, which can't scale, yet still it won't refuse caps that
are not exactly the size of the window and will crop or center the image as
needed.

Or is this not possible/desirable in this case?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list