[Bug 780976] webrtcdsp: do not fail to start if webrtcechoprobe is not found

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 6 17:46:56 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=780976

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
As I mention to George today, clearly the doc and implementation has diverged.
Implementing the doc is indeed error prone, since if it didn't find a probe, it
will never find it later, hence echo-cancellation will never work.

To me, the obvious approach is to make this property dynamic, so you could
enable it at run-time. In that case, enabling while there is no probe should
raise an error. Any other solution, fixing the doc, or this, is of course
acceptable, but seems like the poor way. In any case, it's pretty wrong to rely
on this in your application.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list