[Bug 780976] webrtcdsp: do not fail to start if webrtcechoprobe is not found

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Apr 6 17:47:51 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=780976

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 349387:
 --> (https://bugzilla.gnome.org/review?bug=780976&attachment=349387)

::: ext/webrtcdsp/gstwebrtcdsp.cpp
@@ +521,3 @@
+      GST_WARNING_OBJECT (self, "No echo probe with name %s found, "
+          "disabling echo cancellation", self->probe_name);
+      self->echo_cancel = FALSE;

My concern here is that you are changing a value set by the user. Worst to
that, you are not even notifying the property change.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list