[Bug 780442] vaapi: wayland: multiple sinks blocks the pipeline

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780442

--- Comment #22 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #20)
> @Hyunjun
> 
> I'm not a big fan of threads. IMO we should avoid them as much as possible.
> And I think the solution for these issues can be done without a thread
> (though, threads will be required when we handle foreign windows - bug
> 705821 -).
> 
> Thus, I have sketched a solution, based on your work, removing the thread,
> and it seems to work. You can pull the branch from my repo:
> 
> https://github.com/ceyusa/gstreamer-vaapi/commits/780442
> 
> commit 896a836f reopens and fixes bug 773689 by pushing a modified version
> of the patch proposed in that bug
> commit ca314a25 fixes bug 774029
> commit 33282bb0 fixes this bug 780442
> 
> And two patches more to enhance a couple thinks that your patches here
> proposed.
> 
> Please try them and let me know how they go.

I've tried and confirmed it's working fine, but there are 2 things to mention.
what do you think about adding to remove those codes below in the 4th commit?

if (priv->last_frame) {
  frame_state_free (priv->last_frame);
  priv->last_frame = NULL;
}

It causes segfault(only after 4th commit). Even it's fixed by the 5th commit,
they're not necessary IMO.

Another thing is about skipping frame when there is pending frame.
I think it's neccessary, but not critical.

BTW, I'm not a fan of thread either :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.