[Bug 780442] vaapi: wayland: multiple sinks blocks the pipeline

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=780442

--- Comment #23 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #22)
> I've tried and confirmed it's working fine, but there are 2 things to
> mention.
> what do you think about adding to remove those codes below in the 4th commit?
> 
> if (priv->last_frame) {
>   frame_state_free (priv->last_frame);
>   priv->last_frame = NULL;
> }
> 
> It causes segfault(only after 4th commit). Even it's fixed by the 5th
> commit, they're not necessary IMO.

Good catch! I'll do that.

> 
> Another thing is about skipping frame when there is pending frame.
> I think it's neccessary, but not critical.

I don't think it is necessary, since we wait for each frame to be released.

> 
> BTW, I'm not a fan of thread either :)

:D

I'm going to push the branch with your modification and close this bug. Any
other issue, please reopen it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.