[Bug 783803] encoder: h264(AVC): Add multi reference support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783803

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #11)
> (In reply to Víctor Manuel Jáquez Leal from comment #7)
> > Review of attachment 356499 [details] [review] [review]:
> > 
> > ::: gst-libs/gst/vaapi/gstvaapiencoder.c
> > @@ +1532,3 @@
> > +gboolean
> > +gst_vaapi_encoder_ensure_max_num_ref_frames (GstVaapiEncoder * encoder,
> > +    GstVaapiProfile profile, GstVaapiEntrypoint entrypoint)
> > 
> > Perhaps I'm missing something, but encoder has GstVaapiContext and it keeps
> > the profile and entrypoint, so there is no need to pass them.
> > 
> > ::: gst-libs/gst/vaapi/gstvaapiencoder_priv.h
> > @@ +417,3 @@
> >      guint media_max_slices, guint * num_slices);
> >  
> > +G_GNUC_INTERNAL
> > 
> > I did the same mistake in gst_vaapi_encoder_ensure_num_slices() I shall fix
> > it.
> 
> This was the first problem since I started working on this issue.
> I thought that gst_vaapi_encoder_ensure_num_slices had same problem.
> The function reset_properties is executed before set_context_info, which
> means GstVaapiContext is not completed at this moment. But obviously encoder
> needs the information of the query result at this moment.

I'm stupid. That's is described in both functions' documentation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.