[Bug 783803] encoder: h264(AVC): Add multi reference support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 1 08:54:40 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=783803

--- Comment #14 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 356501:
 --> (https://bugzilla.gnome.org/review?bug=783803&attachment=356501)

lgtm... but I would like to test it before merge it ;)

::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +2518,3 @@
+
+  if (base_encoder->max_num_ref_frames_1 < 1) {
+    if (encoder->num_bframes > 0) {

this can be simplified by using an "&&" operator

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list