[Bug 783803] encoder: h264(AVC): Add multi reference support
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Aug 1 09:01:04 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=783803
--- Comment #15 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 356501:
--> (https://bugzilla.gnome.org/review?bug=783803&attachment=356501)
::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
@@ +2861,3 @@
+ base_encoder->num_ref_frames = (encoder->num_ref_frames
+ + (encoder->num_bframes > 0) + DEFAULT_SURFACES_COUNT)
personally I prefer:
(encoder->num_bframes > 0 ? 1 : 0)
making explicit the use of integers, rather than implicitly cast a boolean
value. I think it is more readable.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list